I have no idea why this irks me. But it does. A lot.
if( NULL != ptr )
{
hr = func( ptr );
}
if( S_OK != hr )
{
// blah blah
}
Highlight that text with your cursor (but not the whole post—just the, ahem, "code" snippet). If your browser is like mine, you'll see extra whitespace on the empty line, and after the first closing curly brace. If your browser isn't like mine (and you're not seeing the highlighted whitespace) just pretend it's there.
Code hygiene, people. Come on.
Not having the variable on the left side of the comparison is what makes my OCD come out.
yeah, I'm forced to agree with Danny. That bugs more than the whitespace. :o)
So how do you protect against typos that accidentally assign the variable in the conditional?
Compiling at /w4 works fine when you're the only dev in the code and when the code is brand-spanking-new, but isn't a realistic long-term solution.
--D
I agree with Dan on both counts. Keeping the constant on the left is an easy way to avoid a simple, yet potentially devastating bug. The whitespace bugs me because it always makes my editor move my cursor to places I don't want it to go when looking through or changing the code. It's almost as bad as code that uses actual tab characters instead of spaces. It never works universally in all editors and viewers.
:g/^v<tab>/s// /g to the rescue!
I didn't say that it was better to have the constant on the right - just that it bugged me more than the whitespace. :o)